[#QTBUG-6242] QGraphicsTextItem::setDefaultTextColor doesn't check whether input is the same as the current value

QGraphicsTextItem::setDefaultTextColor doesn't check whether input is the same as the current value

Created: 25/Nov/09 11:01 PM Updated: 30/Nov/09 03:55 PM

Component/s:

GraphicsView

Affects Version/s:

4.6.1

Fix Version/s:

4.6.1

Time Tracking:

Not Specified

Changes:

c8494e085cd5abc3b30229409c7dacac676c81b9

Description

« Hide

QGraphicsTextItem::setDefaultTextColor does not check whether the given color is already the defaultTextColor. On some systems, this results in infinite loops if the paintEvent calls setDefaultTextColor. This is for example necessary when the QGraphicsTextItem is colored with a KStatefulBrush. See http://websvn.kde.org/?view=rev&revision=1054334 for an example of where this issue occurs, and how a workaround solved the problem.

All

Comments

Work Log

Change History

Transitions

Sort Order:

[ Permalink | « Hide ]

Olivier Goffart added a comment - 25/Nov/09 11:07 PM

Regression since 327ef9127aba3aa6bf2

[ Permalink | « Hide ]

Stefan Majewsky added a comment - 28/Nov/09 12:06 AM

The same thing is true for QAbstractGraphicsShapeItem::{setBrush,setPen}. Unfortunately, I do not have a Qt checkout, so I cannot check whether this has been caused by the same commit.

[ Permalink | « Hide ]

Olivier Goffart added a comment - 30/Nov/09 03:55 PM

setBrush,setPen have always updated, so just do not call them from the paintEvent.
This is not a regression.